refactor(module:steps): refactor steps #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzhudev
changed the title
Codecov Report
@@ Coverage Diff @@
## next #2512 +/- ##
==========================================
+ Coverage 95.72% 95.72% +<.01%
==========================================
Files 491 491
Lines 12245 12209 -36
Branches 1681 1681
==========================================
- Hits 11721 11687 -34
+ Misses 153 152 -1
+ Partials 371 370 -1
Continue to review full report at Codecov.
|
vthinkxie
reviewed
Nov 26, 2018
| @@ -41,4 +35,4 @@ | |||
| <div class="ant-steps-item-description"> | |||
| <ng-container *ngIf="isDescriptionString; else descriptionTemplate">{{ nzDescription }}</ng-container> | |||
vthinkxie
reviewed
Nov 26, 2018
| selector : 'nz-steps', | ||
| preserveWhitespaces: false, | ||
| templateUrl : './nz-steps.component.html' |
vthinkxie
reviewed
Nov 26, 2018
| get nzCurrent(): number { | ||
| return this._current; | ||
| ngOnDestroy(): void { | ||
| this.unsubscribe$.next(); |
vthinkxie
reviewed
Nov 26, 2018
|
|
||
| @Input() | ||
| get nzIcon(): NgClassType | TemplateRef<void> { return this._icon; } |
There was a problem hiding this comment.
all setter should be after getter
https://angular.io/guide/component-interaction#intercept-input-property-changes-with-a-setter
* support label placement
vthinkxie
added a commit
that referenced
this pull request
Nov 30, 2018
* docs: update NG-ZORRO logo (#2425) * fix(module:collapse): can't fold up active panel with accordion (#2440) close #2437 * chore: update styles(ant-design 3.10.7) (#2432) * chore: update styles(ant-design 3.10.8) (#2475) * feat: Adds danish locale (#2486) close #2485 * fix(module:menu): fix dropdown menu item selected className (#2434) close #2433 * fix(module:list): fix invalid render empty style when unspecified data source (#2415) close #2385 * docs(module:modal): add missing nzClassName property (#2400) * docs: add faq in icons docs (#2459) * fix(module:menu): fix fold menu (#2454) close #2449 * refactor(module:all): use cdk keycodes instead of magic number (#2499) * release(1.8.1): release 1.8.1 (#2523) * chore: update styles(ant-design 3.10.9) (#2525) * fix(readme): fix misspelling (#2472) * refactor(module:all): support Angular 7.0 (#2372) * refactor(module:all): refactor component to support onPush & SSR * refactor(module:badge): refactor badge * refactor(module:button & card): refactor * test(module:button): fix test case * fix(module:avatar): fix avatar * fix(module:tree): fix tree tslint * fix(module:tree): fix tree module * fix(module:all): fix tslint config * refactor(module:all): upgrade to angular 7.0 * fix(module:all): fix typescript error * fix(module:build): fix build less options * fix(module:integration): fix webpack test * build: rm unused package * build: fix build & ci * test(module:spin): fix test error * docs: update readme * refactor(module:checkbox): support checkbox onPush (#2478) * docs: update NG-ZORRO logo (#2425) * fix(module:collapse): can't fold up active panel with accordion (#2440) close #2437 * chore: update styles(ant-design 3.10.7) (#2432) * refactor(module:checkbox): support checkbox onPush * refactor(module:collapse): support onPush in collapse (#2481) * refactor(module:divider): refactor divider (#2482) ref #2381 * refactor(module:form): refactor form (#2493) * refactor(module:grid): refactor grid module (#2498) * refactor(module:layout): refactor layout (#2500) * feat(module:progress): support custom strokeColor and strokeLinecap (#2404) close #2378 * feat(module:avatar): support custom size (#2416) close #2380 * fix(module:timeline): fix loading icon (#2386) close #2377 * feat(module:drawer): add input property in NzDrawerRef (#2464) close #2403 * refactor(module:radio): refactor radio to support OnPush (#2519) * refactor(module:spin): refactor spin (#2530) * refactor(module:alert & card): refactor card & refactor template outlet (#2532) * refactor(module:switch & checkbox): refactor switch & checkbox (#2533) * refactor(module:core): refactor input convert decorators (#2535) ref #2474 * refactor(module:mention): refactor mention (#2510) ref: #2381 * refactor(module:steps): refactor steps (#2512) ref #2381 * feat(module:modal): support clicking ESC to close modal (#2483) close #1999 * refactor(module:breadcrumb): refactor breadcrumb (#2513) ref #2381 * refactor(module:skeleton): refactor skeleton (#2514) ref #2381 * refactor(module:icon): refactor icon (#2517) ref #2381 * refactor(module:tree-select): refactor tree-select (#2528) ref: #2381 * build: bump webpack integration (#2524) build: bump webpack integration * refactor(module:timeline): refactor timeline (#2515) close #2379 * support alternate positions, alternate and right alternate * support reversing * refactor(module:autocomplete): refactor autocomplete (#2505) ref #2381, close #2420 * refactor(module:cascader): refactor cascader (#2516) * refactor(module:cascader): refactor cascader close #2935 ref #2198 * fix(module:cascader): fix isFocused access * refactor(module:avatar): refactor avatar (#2536) * fix(module:avatar): fix text style * refactor(module:avatar): refactor avatar ref: #2381 * refactor(module:upload): refactor upload (#2555) * refactor(module:upload): refactor upload - feat: add `nzOpenFileDialogOnClick` prop to allow setting whether to open the upload dialog when the component is clicked * chore: add encapsulation:ViewEncapsulation.None ref #2381 * refactor(module:list): refactor list (#2548) * refactor(module:list): refactor list * fix: import scrolling in share module * chore: add encapsulation:ViewEncapsulation.None ref #2381 * refactor(module:transfer): refactor transfer (#2553) * refactor(module:transfer): refactor transfer - feat: add nzDisabled property - need verify design details, ant-design/ant-design#13330 * chore: search muse be disabled * chore: add encapsulation:ViewEncapsulation.None ref #2381 * refactor(module:back-top): refactor back-top (#2547) refactor(module:back-top): refactor back-top * refactor(module:anchor): refactor anchor (#2546) * refactor(module:anchor): refactor anchor - feat: the nzTarget support string value - fix: invalid id in demo * chore: add encapsulation:ViewEncapsulation.None * chore: add encapsulation:ViewEncapsulation.None * chore: fix display style in host * chore: remove :host ref #2381 * refactor(module:affix): refactor affix (#2544) * refactor(module:affix): refactor affix - the nzTarget support string value * fix: release * style: removed no-any in first line * fix: fix style * chore: fix test * chore: fix display style in host * chore: remove :host
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information